PEP8 Builder.py

This commit is contained in:
Sean Davis 2014-04-01 21:49:46 -04:00
parent 2da1541586
commit 310c7d983c
1 changed files with 10 additions and 11 deletions

View File

@ -54,8 +54,7 @@ class Builder(Gtk.Builder):
# pylint: disable=R0201 # pylint: disable=R0201
# this is a method so that a subclass of Builder can redefine it # this is a method so that a subclass of Builder can redefine it
def default_handler(self, def default_handler(self, handler_name, filename, *args, **kwargs):
handler_name, filename, *args, **kwargs):
'''helps the apprentice guru '''helps the apprentice guru
glade defined handlers that do not exist come here instead. glade defined handlers that do not exist come here instead.
@ -99,8 +98,8 @@ class Builder(Gtk.Builder):
connections = [ connections = [
(name, (name,
ele_signal.attrib['name'], ele_signal.attrib['name'],
ele_signal.attrib['handler']) for ele_signal in ele_signals] ele_signal.attrib['handler']) for ele_signal in ele_signals]
if connections: if connections:
self.connections.extend(connections) self.connections.extend(connections)
@ -108,7 +107,7 @@ class Builder(Gtk.Builder):
ele_signals = tree.getiterator("signal") ele_signals = tree.getiterator("signal")
for ele_signal in ele_signals: for ele_signal in ele_signals:
self.glade_handler_dict.update( self.glade_handler_dict.update(
{ele_signal.attrib["handler"]: None}) {ele_signal.attrib["handler"]: None})
def connect_signals(self, callback_obj): def connect_signals(self, callback_obj):
'''connect the handlers defined in glade '''connect the handlers defined in glade
@ -130,7 +129,7 @@ class Builder(Gtk.Builder):
# replace the run time warning # replace the run time warning
logger.warn("expected handler '%s' in %s", logger.warn("expected handler '%s' in %s",
item[0], filename) item[0], filename)
# connect glade define handlers # connect glade define handlers
Gtk.Builder.connect_signals(self, connection_dict) Gtk.Builder.connect_signals(self, connection_dict)
@ -139,7 +138,7 @@ class Builder(Gtk.Builder):
for connection in self.connections: for connection in self.connections:
widget_name, signal_name, handler_name = connection widget_name, signal_name, handler_name = connection
logger.debug("connect builder by design '%s', '%s', '%s'", logger.debug("connect builder by design '%s', '%s', '%s'",
widget_name, signal_name, handler_name) widget_name, signal_name, handler_name)
def get_ui(self, callback_obj=None, by_name=True): def get_ui(self, callback_obj=None, by_name=True):
'''Creates the ui object with widgets as attributes '''Creates the ui object with widgets as attributes
@ -203,7 +202,7 @@ def make_pyname(name):
pyname = '' pyname = ''
for character in name: for character in name:
if (character.isalpha() or character == '_' or if (character.isalpha() or character == '_' or
(pyname and character.isdigit())): (pyname and character.isdigit())):
pyname += character pyname += character
else: else:
pyname += '_' pyname += '_'
@ -288,13 +287,13 @@ def auto_connect_by_name(callback_obj, builder):
handler_names.append("on_%s" % sig) handler_names.append("on_%s" % sig)
do_connect(item, sig, handler_names, do_connect(item, sig, handler_names,
callback_handler_dict, builder.connections) callback_handler_dict, builder.connections)
log_unconnected_functions(callback_handler_dict, builder.connections) log_unconnected_functions(callback_handler_dict, builder.connections)
def do_connect(item, signal_name, handler_names, def do_connect(item, signal_name, handler_names,
callback_handler_dict, connections): callback_handler_dict, connections):
'''connect this signal to an unused handler''' '''connect this signal to an unused handler'''
widget_name, widget = item widget_name, widget = item
@ -307,7 +306,7 @@ def do_connect(item, signal_name, handler_names,
connections.append(connection) connections.append(connection)
logger.debug("connect builder by name '%s','%s', '%s'", logger.debug("connect builder by name '%s','%s', '%s'",
widget_name, signal_name, handler_name) widget_name, signal_name, handler_name)
def log_unconnected_functions(callback_handler_dict, connections): def log_unconnected_functions(callback_handler_dict, connections):