From 60320cbc2c6c8405d24f42c1a7fd5876d765ccbc Mon Sep 17 00:00:00 2001 From: Edward Muller Date: Thu, 5 Sep 2019 16:09:16 -0700 Subject: [PATCH] return early This makes it easier to read / understand and is more idiomatic. --- entry.go | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/entry.go b/entry.go index 63e2558..7e2c899 100644 --- a/entry.go +++ b/entry.go @@ -255,11 +255,10 @@ func (entry *Entry) write() { serialized, err := entry.Logger.Formatter.Format(entry) if err != nil { fmt.Fprintf(os.Stderr, "Failed to obtain reader, %v\n", err) - } else { - _, err = entry.Logger.Out.Write(serialized) - if err != nil { - fmt.Fprintf(os.Stderr, "Failed to write to log, %v\n", err) - } + return + } + if _, err = entry.Logger.Out.Write(serialized); err != nil { + fmt.Fprintf(os.Stderr, "Failed to write to log, %v\n", err) } }